Skip to content

Conversation

@silesky
Copy link
Contributor

@silesky silesky commented Apr 7, 2025

This page-tools library is required in order to have something for signals consume, without making analytics-next a dependency of signals. This is a requirement for granular navigation work we want to do for signals.

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2025

🦋 Changeset detected

Latest commit: 3920a8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@segment/analytics-next Minor
@segment/analytics-page-tools Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky requested a review from alanjcharles April 7, 2025 21:52
@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.84%. Comparing base (bc32a3d) to head (3920a8c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
+ Coverage   83.80%   83.84%   +0.04%     
==========================================
  Files         222      223       +1     
  Lines        5890     5906      +16     
  Branches     1346     1346              
==========================================
+ Hits         4936     4952      +16     
  Misses        954      954              
Flag Coverage Δ
browser 92.16% <100.00%> (-0.12%) ⬇️
core 89.86% <ø> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

alanjcharles
alanjcharles previously approved these changes Apr 7, 2025
alanjcharles
alanjcharles previously approved these changes Apr 8, 2025
@silesky silesky merged commit f2c2b76 into master Apr 9, 2025
8 checks passed
@silesky silesky deleted the add-analytics-page-library branch April 9, 2025 18:57
@github-actions github-actions bot mentioned this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants